wicket-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Emond Papegaaij (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WICKET-4074) RequestLogger needs a clear separation of concerns
Date Mon, 03 Oct 2011 10:57:33 GMT

    [ https://issues.apache.org/jira/browse/WICKET-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119239#comment-13119239
] 

Emond Papegaaij commented on WICKET-4074:
-----------------------------------------

The data is available when the 'performLogging' method is called on IStagedRequestLogger.
That's the reason why that interface is needed, it should be merged into IRequestLogger in
wicket.next.

I don't see why a second logger is needed for that. We already log RequestLogger data to another
file, without using a second logger. We use a second appender and configure log4j to use this
appender for the request logger.
                
> RequestLogger needs a clear separation of concerns
> --------------------------------------------------
>
>                 Key: WICKET-4074
>                 URL: https://issues.apache.org/jira/browse/WICKET-4074
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.5.1
>            Reporter: Emond Papegaaij
>         Attachments: 0001-improved-request-logger.patch, 0002-remove-generic-type-from-ILoggableRequestHandler.patch,
0003-move-LogData-to-handler.logger.patch, 0004-make-logdata-members-final.patch, 0005-json-request-logger-using-jackson.patch,
ALL-new-request-logger.patch
>
>
> As a follow-up on WICKET-3919 and WICKET-4029, I've been working on a patch for the RequestLogger.
This patch makes RequestHandles responsible for providing data to log. The RequestLogger collects
this data and logs it. RequestHandles that are to be logged, must implement ILoggableRequestHandle.
> In short, this patch changes the following things:
> ILoggableRequestHandle added and all major RequestHandles changed to implement this interface
> IStatedRequestLogger added and AbstractRequestLogger changed to implement this interface
(separate logging step after the detach phase)
> Various implementations of ILogData added (data logged by request handlers)
> RequestLogger simplified to use ILoggableRequestHandle

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message