Return-Path: Delivered-To: apmail-wicket-commits-archive@www.apache.org Received: (qmail 67927 invoked from network); 2 Jun 2009 03:04:17 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 2 Jun 2009 03:04:17 -0000 Received: (qmail 89937 invoked by uid 500); 2 Jun 2009 03:04:29 -0000 Delivered-To: apmail-wicket-commits-archive@wicket.apache.org Received: (qmail 89870 invoked by uid 500); 2 Jun 2009 03:04:29 -0000 Mailing-List: contact commits-help@wicket.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@wicket.apache.org Delivered-To: mailing list commits@wicket.apache.org Received: (qmail 89861 invoked by uid 99); 2 Jun 2009 03:04:29 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Jun 2009 03:04:29 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Jun 2009 03:04:27 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 5759C234C004 for ; Mon, 1 Jun 2009 20:04:07 -0700 (PDT) Message-ID: <1972281168.1243911847343.JavaMail.jira@brutus> Date: Mon, 1 Jun 2009 20:04:07 -0700 (PDT) From: "Alex Gitelman (JIRA)" To: commits@wicket.apache.org Subject: [jira] Updated: (WICKET-2297) DiskPageStore does not unbind expired sessions In-Reply-To: <1712763328.1243830967359.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/WICKET-2297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Gitelman updated WICKET-2297: ---------------------------------- Description: I am having a problem similar to described in WICKET-1679. I am getting application filled with sessions from googlebot and they never go away so application dies and DiskPageStore repository at this point contains 5000-6000 files (after two days of idling with no real users). I placed following in my application. protected ISessionStore newSessionStore() { return new SecondLevelCacheSessionStore(this, new DiskPageStore() { public void unbind(String sessionId) { super.unbind(sessionId); _log.debug("Unbound session in DiskPageStore id: " + sessionId); } }) { protected void onUnbind(String sessionId) { _log.debug("Unbind session id: " + sessionId); } }; } And I set session timeout in web.xml to 1 minute. After I hit the application, output in tomcat is this Unbind session id: 27DEE9B9778DEA469613972C28A009F9 I expected to see 2 messages: Unbound session in DiskPageStore id: 27DEE9B9778DEA469613972C28A009F9 and Unbind session id: 27DEE9B9778DEA469613972C28A009F9 So DiskPageStore retains all sessions, even expired ones. In addition, I am not sure if DiskPageStore clears non existing sessions upon server restart, so unless I manually clean the repository, I load all of them again. was: I am having a problem similar to described in WICKET-1679. I am getting application filled with sessions from googlebot and they never go away so application dies and DiskPageStore repository at this point contains 5000-6000 files (after two days of idling with no real users). I placed following in my application. protected ISessionStore newSessionStore() { return new SecondLevelCacheSessionStore(this, new DiskPageStore() { public void unbind(String sessionId) { super.unbind(sessionId); _log.debug("Unbound session in DiskPageStore id: " + sessionId); } }) { protected void onUnbind(String sessionId) { _log.debug("Unbind session id: " + sessionId); } }; } And I set session timeout in web.xml to 1 minute. After I hit the application, output in tomcat is this Unbind session id: 27DEE9B9778DEA469613972C28A009F9 I expected to see 2 messages: Unbound session in DiskPageStore id: 27DEE9B9778DEA469613972C28A009F9 and Unbind session id: 27DEE9B9778DEA469613972C28A009F9 So DiskPageStore retains all sessions, even expire ones. In addition, I am not sure id DiskPageStore clears non existing sessions upon server restart, so unless I manually clean the repository, I load all of them again. > DiskPageStore does not unbind expired sessions > ---------------------------------------------- > > Key: WICKET-2297 > URL: https://issues.apache.org/jira/browse/WICKET-2297 > Project: Wicket > Issue Type: Bug > Components: wicket > Affects Versions: 1.3.6, 1.4-RC4 > Reporter: Alex Gitelman > Priority: Critical > > I am having a problem similar to described in WICKET-1679. > I am getting application filled with sessions from googlebot and they never go away so application dies and DiskPageStore repository at this point contains 5000-6000 files (after two days of idling with no real users). > I placed following in my application. > protected ISessionStore newSessionStore() > { > return new SecondLevelCacheSessionStore(this, new DiskPageStore() > { > public void unbind(String sessionId) { > super.unbind(sessionId); > _log.debug("Unbound session in DiskPageStore id: " + sessionId); > } > }) > { > protected void onUnbind(String sessionId) { > _log.debug("Unbind session id: " + sessionId); > } > }; > } > And I set session timeout in web.xml to 1 minute. After I hit the application, output in tomcat is this > Unbind session id: 27DEE9B9778DEA469613972C28A009F9 > I expected to see 2 messages: > Unbound session in DiskPageStore id: 27DEE9B9778DEA469613972C28A009F9 > and > Unbind session id: 27DEE9B9778DEA469613972C28A009F9 > So DiskPageStore retains all sessions, even expired ones. > In addition, I am not sure if DiskPageStore clears non existing sessions upon server restart, so unless I manually clean the repository, I load all of them again. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.