wicket-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Peter Ertl (JIRA)" <j...@apache.org>
Subject [jira] Updated: (WICKET-1568) contribution for wicket 1.4 generics (IConverter)
Date Sat, 03 May 2008 10:52:55 GMT

     [ https://issues.apache.org/jira/browse/WICKET-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Peter Ertl updated WICKET-1568:
-------------------------------

    Description: 
I think it will be straightforward to let the converter of a component handle the same type
<T> that the component itself uses

----------------------

public class MyMoneyTextField extends TextField<BigDecimal>
{
  public MyMoneyTextField(final String id, final IModel<BigDecimal> model)
  {
    super(id, model);
  }

  // ...
  
  @Override
  public IConverter<BigDecimal> getConverter(final Class<BigDecimal> type)
  {
    // no ugly casts here anymore :-)
    //
    return new IConverter<BigDecimal>()
    {
      public BigDecimal convertToObject(final String value, final Locale locale)
      {
        // ...
      }

      public String convertToString(final BigDecimal value, final Locale locale)
      {
        // ...
      }
    };
  }
}


I attached a patch that implements this change and ask you to take a look at and integrate
it if you consider it right and helpful.

Best regards
Peter

  was:
I think it will be straightforward to let the converter of a component handle the same type
<T> that the component itself uses

----------------------

public class MyMoneyTextField extends TextField<BigDecimal>
{
  public MyMoneyTextField(final String id, final IModel<BigDecimal> model)
  {
    super(id, model);
  }

  // ...
  
  @Override
  public IConverter<BigDecimal> getConverter(final Class<BigDecimal> type)
  {
    return new IConverter<BigDecimal>()
    {
      public BigDecimal convertToObject(final String value, final Locale locale)
      {
        // ...
      }

      public String convertToString(final BigDecimal value, final Locale locale)
      {
        // ...
      }
    };
  }
}


I attached a patch that implements this change and ask you to take a look at and integrate
it if you consider it right and helpful.

Best regards
Peter


> contribution for wicket 1.4 generics (IConverter)
> -------------------------------------------------
>
>                 Key: WICKET-1568
>                 URL: https://issues.apache.org/jira/browse/WICKET-1568
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>            Reporter: Peter Ertl
>         Attachments: converter.patch
>
>
> I think it will be straightforward to let the converter of a component handle the same
type <T> that the component itself uses
> ----------------------
> public class MyMoneyTextField extends TextField<BigDecimal>
> {
>   public MyMoneyTextField(final String id, final IModel<BigDecimal> model)
>   {
>     super(id, model);
>   }
>   // ...
>   
>   @Override
>   public IConverter<BigDecimal> getConverter(final Class<BigDecimal> type)
>   {
>     // no ugly casts here anymore :-)
>     //
>     return new IConverter<BigDecimal>()
>     {
>       public BigDecimal convertToObject(final String value, final Locale locale)
>       {
>         // ...
>       }
>       public String convertToString(final BigDecimal value, final Locale locale)
>       {
>         // ...
>       }
>     };
>   }
> }
> I attached a patch that implements this change and ask you to take a look at and integrate
it if you consider it right and helpful.
> Best regards
> Peter

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message