wicket-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Syrstad (JIRA)" <j...@apache.org>
Subject [jira] Commented: (WICKET-466) [datetime] Make DateConverter focus on joda-time.DateTime instead of util.Date
Date Mon, 01 Oct 2007 17:17:50 GMT

    [ https://issues.apache.org/jira/browse/WICKET-466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12531573
] 

Dan Syrstad commented on WICKET-466:
------------------------------------

Joda date formats can break the generated JS because Joda allows single quotes in the string
to escape text. For example, a Joda date format of "MM/dd/yyyy' 'HH:mm:ss" causes the following
JS to be generated in 1.3beta3

Wicket.DateTime.showCalendar(YAHOO.wicket.dateTextField9DpJs, YAHOO.util.Dom.get("dateTextField9").value,
'MM/dd/yyyy' 'HH:mm:ss');

This is a JS error because there are 2 strings erroneously generated: 'MM/dd/yyyy' and 'HH:mm:ss'.


> [datetime] Make DateConverter focus on joda-time.DateTime instead of util.Date
> ------------------------------------------------------------------------------
>
>                 Key: WICKET-466
>                 URL: https://issues.apache.org/jira/browse/WICKET-466
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket-datetime
>    Affects Versions: 1.3.0-beta1
>            Reporter: Chuck Deal
>            Assignee: Eelco Hillenius
>            Priority: Minor
>             Fix For: 1.4.0-alpha
>
>         Attachments: datetime_patch.txt, datetime_patch.txt, datetime_patch.txt, datetime_patch.txt,
datetime_patch.txt, quickstart-datetimeconverter.zip
>
>
> I beleive the Wicket-datetime package was designed to be used with joda-time DateTime
objects.  It was also desirable to apply the "better" parsing/toString features of DateTime
to util.Date objects.  To that end, the attached patch improves the focus of the Converter
to be DateTime oriented, while still allowing the DateTextField to hold util.Dates in it's
model.
> The main idea of this patch is to make this package work with DateTime objects with very
little effort on the developer's part.  If they want to take advantage of the improved parsing,
etc then it should take minimal effort.
> See http://www.nabble.com/-datetime--DateConverter-tf3233793.html for a brief history
of this conversation.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message