wicket-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Juergen Donnerstag (JIRA)" <j...@apache.org>
Subject [jira] Commented: (WICKET-695) Border.resolve() should not attempt to render contents if bodyVisible is false
Date Sun, 01 Jul 2007 13:17:04 GMT

    [ https://issues.apache.org/jira/browse/WICKET-695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12509375
] 

Juergen Donnerstag commented on WICKET-695:
-------------------------------------------

Until we find a way to solve the problems mentioned above, this is the code necessary to not
render the body markup and its components

	public final boolean resolve(final MarkupContainer container, final MarkupStream markupStream,
			final ComponentTag tag)
	{
		// Determine if tag is a <wicket:body> tag
		if (!(tag instanceof WicketTag))
		{
			return false;
		}

		final WicketTag wtag = (WicketTag)tag;
		if (!wtag.isBodyTag())
		{
			return false;
		}

		final Response originalResponse;
		if (this.bodyVisible == true)
		{
			renderBodyComponent(markupStream, wtag);
		}
		else
		{
			// skip <wicket:body> component
			markupStream.skipComponent();
			
			// skip <xxx wicket:id="myBorder">
			Border border = findBorder();
			border.haveSeenBodyTag = true;
			final MarkupStream origBorderMarkup = border.getMarkupStream();
			border.setMarkupStream(null);
			final MarkupStream borderMarkup = border.findMarkupStream();
			borderMarkup.setCurrentIndex(borderMarkup.getCurrentIndex() - 1);
			borderMarkup.skipComponent();
			borderMarkup.setCurrentIndex(borderMarkup.getCurrentIndex() - 1);
			border.setMarkupStream(origBorderMarkup);
		}

		return true;
	}


> Border.resolve() should not attempt to render contents if bodyVisible is false
> ------------------------------------------------------------------------------
>
>                 Key: WICKET-695
>                 URL: https://issues.apache.org/jira/browse/WICKET-695
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-beta1, 1.3.0-beta2, 1.3.0-beta3
>            Reporter: Stefan Kanev
>            Assignee: Juergen Donnerstag
>            Priority: Minor
>
> Border.resolve() should not attempt to render its nested components if setBorderBodyVisible(false)
has been called. This way the behavior would be similar to Component.setVisible() - when the
contents are not visible, wicket would not raise an exception if there are no corresponding
components for the border's markup.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message