wicket-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jean-Baptiste Quenot (JIRA)" <j...@apache.org>
Subject [jira] Updated: (WICKET-329) Improve AbstractDetachableModel error messages
Date Thu, 01 Mar 2007 10:59:51 GMT

     [ https://issues.apache.org/jira/browse/WICKET-329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jean-Baptiste Quenot updated WICKET-329:
----------------------------------------

    Fix Version/s: 1.3
          Summary: Improve AbstractDetachableModel error messages  (was: I propose a slight
change to setObject exception message )

> Improve AbstractDetachableModel error messages
> ----------------------------------------------
>
>                 Key: WICKET-329
>                 URL: https://issues.apache.org/jira/browse/WICKET-329
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.3
>            Reporter: Chuck Deal
>         Assigned To: Jean-Baptiste Quenot
>            Priority: Minor
>             Fix For: 1.3
>
>
> In my specific case it is Wicket 1.3, AbstractDetachableModel, setObject();  but I image
it would apply in other cases as well. 
> Does anyone else see any value to making this small change to the exception message?

> Currently: 
> throw new WicketRuntimeException("unable to set object " + object + ", model: " + this

>                                         + ", called with component " + component, e);

> Proposed: 
> throw new WicketRuntimeException("unable to set object " + object + "\nmodel: " + this

>                                         + "\n called with component " + component, e);

> Basically, put the three parts of the exception on different lines.  Why?  Well, the
toString output of the model that is attached to the failing component is HUGE and it makes
it hard to find the exception "readily".  Having the parts on different lines would allow
me to easily recognize the component that is failing instead of have to search for the phrase
"called with component" in the error message to seek to the correct location in the message.

> I know, it is trivial to search the message, but I am a fan of the tool working for me.
 I would be willing to submit a patch, I would just need to know the approved format as well
as what exceptions message to change. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message