whirr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Heneveld (JIRA)" <j...@apache.org>
Subject [jira] [Issue Comment Edited] (WHIRR-385) Implement support for using nodeless, masterless Puppet to provision and run scripts
Date Mon, 19 Sep 2011 22:20:08 GMT

    [ https://issues.apache.org/jira/browse/WHIRR-385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13108146#comment-13108146
] 

Alex Heneveld edited comment on WHIRR-385 at 9/19/11 10:18 PM:
---------------------------------------------------------------

+1 code changes look good to me; nay, they look great.  Much better test coverage too, and
all passing for me (on EC2).

Developers note, checkstyle complains about missing newlines at the end of {{InstallAllModulesStatementFromProperties}}
and {{KeyToModuleNameOrNull}}; and of course you need a recent checkout (one containing the
WHIRR-371 firewall patch, or apply it yourself before applying this one).

Users note, with this patch module sources must now come from git or local tgz's; local dirs
are no longer supported. (It wasn't a particularly nice implementation, delegating to {{Runtime.exec}}
to make the tar.gz; if this functionality is desired please let us know).


      was (Author: alex.heneveld):
    
+1 code changes look good to me; nay, they look great.  Much better test coverage too, and
all passing for me (on EC2).

Developers note, checkstyle complains about missing newlines at the end of {{InstallAllModulesStatementFromProperties}}
and {{KeyToModuleNameOrNull}}; and of course you need a recent checkout, containing the WHIRR-371
firewall patch.

Users note, with this patch module sources must now come from git or local tgz's; local dirs
are no longer supported. (It wasn't a particularly nice implementation, delegating to {{Runtime.exec}}
to make the tar.gz; if this functionality is desired please let us know).

  
> Implement support for using nodeless, masterless Puppet to provision and run scripts
> ------------------------------------------------------------------------------------
>
>                 Key: WHIRR-385
>                 URL: https://issues.apache.org/jira/browse/WHIRR-385
>             Project: Whirr
>          Issue Type: New Feature
>          Components: new service
>    Affects Versions: 0.7.0
>            Reporter: Alex Heneveld
>         Attachments: WHIRR-385-results-aws-ec2.txt, WHIRR-385-results-cloudservers-us.txt,
WHIRR-385.patch, WHIRR-385.patch, WHIRR-385.patch, WHIRR-385.patch, WHIRR-385.patch, WHIRR-385.patch,
WHIRR-385.patch, WHIRR-385.patch, WHIRR-385.patch, WHIRR-385.patch
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> As a user of Whirr, I'd like to be able to use puppet scripts (manifests, modules) from
within Whirr to set up machines and clusters, because there are a lot of OS-neutral capabilities
and a large number of actively maintained scripts which I could benefit from.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message