Return-Path: X-Original-To: apmail-incubator-whirr-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-whirr-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F3A8F4DC9 for ; Mon, 6 Jun 2011 20:03:23 +0000 (UTC) Received: (qmail 44729 invoked by uid 500); 6 Jun 2011 20:03:23 -0000 Delivered-To: apmail-incubator-whirr-dev-archive@incubator.apache.org Received: (qmail 44686 invoked by uid 500); 6 Jun 2011 20:03:23 -0000 Mailing-List: contact whirr-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: whirr-dev@incubator.apache.org Delivered-To: mailing list whirr-dev@incubator.apache.org Received: (qmail 44678 invoked by uid 99); 6 Jun 2011 20:03:23 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 Jun 2011 20:03:23 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 Jun 2011 20:03:22 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id D47871045ED for ; Mon, 6 Jun 2011 20:03:02 +0000 (UTC) Date: Mon, 6 Jun 2011 20:03:02 +0000 (UTC) From: "Andrei Savu (JIRA)" To: whirr-dev@incubator.apache.org Message-ID: <959500074.1672.1307390582867.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <453730091.66487.1307122967703.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (WHIRR-325) Reduce cloud provider-specific code in scripts MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/WHIRR-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045057#comment-13045057 ] Andrei Savu commented on WHIRR-325: ----------------------------------- > We could use this along with runScriptOnNode() to pass IP addresses, etc. Is this what you had in mind? Exactly. > One possible downside to this approach is that using "whirr run-script" wouldn't be able to set these environment variables We could rewrite "whirr run-script" in terms of runScriptOnNode. Actually I think it would be useful to have a runScriptOnNode method on the ClusterController that would set all the required environment variables and we could call that by using an executor service. > Reduce cloud provider-specific code in scripts > ---------------------------------------------- > > Key: WHIRR-325 > URL: https://issues.apache.org/jira/browse/WHIRR-325 > Project: Whirr > Issue Type: Improvement > Reporter: Tom White > > Many of the bash functions have a cloud provider option (-c) that they use to determine how to find the local public/private IP address, or the local data directory (/mnt vs /data, for example). > We should pass what is needed (e.g. IP addresses, directories), or at least put the code in a common function. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira