whirr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Alves (JIRA)" <j...@apache.org>
Subject [jira] Issue Comment Edited: (WHIRR-221) Optionally control the order of starting services
Date Wed, 09 Feb 2011 19:50:57 GMT

    [ https://issues.apache.org/jira/browse/WHIRR-221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12992684#comment-12992684
] 

David Alves edited comment on WHIRR-221 at 2/9/11 7:49 PM:
-----------------------------------------------------------

Added the ability to specify whirr.role.order exactly as defined in the description of the
issue. Unit tests are passing fine. Please Review!

When a user specifies: 
whirr.role-order=role1+role2,role3,role4,role5
each roles group will start in order i.e.:
role1+role2
role3
role4
role5

When nothing is specified the all roles are started at the same time (per InstanceTemplate
groups).

Limitations:
I've seen some inconsistencies when whirr.instance-templates has mixed roles, i.e.:
1 role1+role2,2 role3,3 role4+role5
works fine
1 role1+role2,2 role3+role3,3 role1+role2+role4+role5
does not. Must look into it further...
- Have not made integration tests as of yet (requires further investigation to make the correct
assertions)

Remarks:
- Added a completely mocked/stubbed ComputeServiceContext to allow to run unit tests cluster
startup.
- Changed the ClusterSpec to account for the new property (and to be able to parse it)
- Added the possibility for ComputeServiceContextBuilder to return a "test" ComputeServiceContext
(the stub)
- Added test whirr*.properties to ease testing in the ordered and not ordered build cases.
- Changed ConfigureClusterAction so that it now runs in parallel both in the unordered and
ordered configure modes.

      was (Author: dr-alves):
    Added the ability to specify whirr.role.order exactly as defined in the description of
the issue. Unit tests are passing fine. Please Review!

When a user specifies: 
whirr.role-order=role1+role2,role3,role4,role5
each roles group will start in order i.e.:
role1+role2
role3
role4
role5

When nothing is specified the all roles are started at the same time (per InstanceTemplate
groups).

Limitations:
I've seen some inconsistencies when whirr.instance-templates has mixed roles, i.e.:
1 role1+role2,2 role3,3 role4+role5
works fine
1 role1+role2,2 role3+role3,3 role1+role2+role4+role5
does not. Must look into it further...
- Have not made integration tests as of yet (requires further investigation to make the correct
assertions)

Remarks:
- Added a completely mocked/stubbed ComputeServiceContext to allow to run unit tests cluster
startup.
- Changed the ClusterSpec to account for the new property (and to be able to parse it)
- Added the possibility for ComputeServiceContextBuilder to return a "test" provider (the
stub)
- Added test whirr*.properties to ease testing in the ordered and not ordered build cases.
- Changed ConfigureClusterAction so that it now runs in parallel both in the unordered and
ordered configure modes.
  
> Optionally control the order of starting services
> -------------------------------------------------
>
>                 Key: WHIRR-221
>                 URL: https://issues.apache.org/jira/browse/WHIRR-221
>             Project: Whirr
>          Issue Type: New Feature
>          Components: core, documentation
>    Affects Versions: 0.4.0
>            Reporter: Andrei Savu
>            Priority: Critical
>             Fix For: 0.4.0
>
>         Attachments: WHIRR-221.patch
>
>
> As Lars sugested in WHIRR-170:
> The user should "be able to optionally control the order (services start). This could
be role based and specified like so
> {code}
> whirr.role-order=zk,nn+jt,dn+tt,hbase-master,hbase-regionserver
> {code}
> If not specified the system should make any effort to start the services as quickly as
possible, for example in multiple threads. In other words, when the role-order is not given
no guarantee about order can be given."

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message