weex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WEEX-653) feature for Rtl layout
Date Sat, 10 Nov 2018 13:17:00 GMT

    [ https://issues.apache.org/jira/browse/WEEX-653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16682397#comment-16682397
] 

ASF GitHub Bot commented on WEEX-653:
-------------------------------------

weex-bot edited a comment on issue #1664: [WEEX-653][android][iOS][core] Total platform support
rtl direction by CSS "direction:rtl"
URL: https://github.com/apache/incubator-weex/pull/1664#issuecomment-432502237
 
 
   
   <!--
     1 failure:  Code file weex_co...
     2 warning:  No Changelog chan..., Potential BREAK C...
     1 messages
     
   -->
   
   <table>
     <thead>
       <tr>
         <th width="50"></th>
         <th width="100%" data-danger-table="true">Fails</th>
       </tr>
     </thead>
     <tbody><tr>
         <td>:no_entry_sign:</td>
         <td>Code file weex_core/Source/android/jniprebuild/jniheader/NativeRenderObjectUtils_jni.h
does not have the copyright header.</td>
       </tr>
     </tbody>
   </table>
   
   
   <table>
     <thead>
       <tr>
         <th width="50"></th>
         <th width="100%" data-danger-table="true">Warnings</th>
       </tr>
     </thead>
     <tbody><tr>
         <td>:warning:</td>
         <td>No Changelog changes!</td>
       </tr>
     
   <tr>
         <td>:warning:</td>
         <td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/ui/component/WXComponent.java
without metion it in commit message. You'd better add '@notdanger' in your commit log. </td>
       </tr>
     </tbody>
   </table>
   
   
   <table>
     <thead>
       <tr>
         <th width="50"></th>
         <th width="100%" data-danger-table="true">Messages</th>
       </tr>
     </thead>
     <tbody><tr>
         <td>:book:</td>
         <td>danger test finished.</td>
       </tr>
     </tbody>
   </table>
   
   
   <p align="right">
     Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
   </p>
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> feature for Rtl layout
> ----------------------
>
>                 Key: WEEX-653
>                 URL: https://issues.apache.org/jira/browse/WEEX-653
>             Project: Weex
>          Issue Type: New Feature
>          Components: Android, iOS, Web Renderer
>    Affects Versions: 0.18
>            Reporter: Kai Tian
>            Assignee: YorkShen
>            Priority: Major
>             Fix For: 0.18
>
>
> [android][ios][core] Whole platform support rtl direction by CSS "direction:rtl"
> [core] Update the new layout engine to support inheritable CSS "direction:rtl".
> [ios][android] Update component layer, to support list, slide, scroller RTL direction.
Update WXEnvironment, now we can get system layout direction by WXEnvironment.layoutDirection.
Update WXDomModule, now we can get element layout direction by getLayoutDirection(ref,callback)
> Few languages such as Arabic, Hebrew, or Persian are written from Right to Left, but
weex not support RTL layouts. To handle them. Since this PR merged, we can use weex for RTL
languages in both android and ios. And Scroller performance like native, layout and scroll
direction will be reverse.
>  
> There are some test Demos: 
> Div+Scroller http://dotwe.org/vue/9c3ee9824dd49111a87a93ea6513039a
> Horizontal Scroller http://dotwe.org/vue/0dd282e3183c2384ec38a465c915ce41
> Scroller (ScrollToElement) http://dotwe.org/vue/a24001978199df6e981673e9460598c8
> Slider http://dotwe.org/vue/7e45bcf71ad396032944bc51541d6350
> Animation http://dotwe.org/vue/b578facdbb623f6922f0905ae09b7e49
> envDirection + getLayoutDirection http://dotwe.org/vue/d6c5cf7a2a907c33cf4ba25fea6e6ef4



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message