weex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] YorkShen closed pull request #1398: * [Android] Change method access level for image
Date Tue, 07 Aug 2018 04:16:27 GMT
YorkShen closed pull request #1398: * [Android] Change method access level for image
URL: https://github.com/apache/incubator-weex/pull/1398
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/android/sdk/src/main/java/com/taobao/weex/ui/component/WXImage.java b/android/sdk/src/main/java/com/taobao/weex/ui/component/WXImage.java
index c366336ec0..df9dcf9600 100644
--- a/android/sdk/src/main/java/com/taobao/weex/ui/component/WXImage.java
+++ b/android/sdk/src/main/java/com/taobao/weex/ui/component/WXImage.java
@@ -18,6 +18,9 @@
  */
 package com.taobao.weex.ui.component;
 
+import android.support.annotation.RestrictTo;
+import android.support.annotation.RestrictTo.Scope;
+import com.taobao.weex.dom.WXImageQuality;
 import java.lang.reflect.InvocationTargetException;
 import java.util.Arrays;
 import java.util.HashMap;
@@ -159,7 +162,8 @@ public void setResizeMode(String resizeMode) {
     (getHostView()).setScaleType(getResizeMode(resizeMode));
   }
 
-  private ScaleType getResizeMode(String resizeMode) {
+  @RestrictTo(Scope.LIBRARY_GROUP)
+  protected ScaleType getResizeMode(String resizeMode) {
     ScaleType scaleType = ScaleType.FIT_XY;
     if (TextUtils.isEmpty(resizeMode)) {
       return scaleType;
@@ -337,10 +341,15 @@ public void onImageFinish(String url, ImageView imageView, boolean result,
Map e
     IWXImgLoaderAdapter imgLoaderAdapter = getInstance().getImgLoaderAdapter();
     if (imgLoaderAdapter != null) {
       imgLoaderAdapter.setImage(rewrited.toString(), getHostView(),
-          getAttrs().getImageQuality(), imageStrategy);
+          getImageQuality(), imageStrategy);
     }
   }
 
+  @RestrictTo(Scope.LIBRARY_GROUP)
+  protected WXImageQuality getImageQuality(){
+    return getAttrs().getImageQuality();
+  }
+
   @Override
   protected void onFinishLayout() {
     super.onFinishLayout();


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message