weex-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-weex] YorkShen commented on issue #2890: Any reason for READ_PHONE_STATE permission?
Date Wed, 11 Sep 2019 10:00:34 GMT
YorkShen commented on issue #2890: Any reason for READ_PHONE_STATE permission?
URL: https://github.com/apache/incubator-weex/issues/2890#issuecomment-530311895
 
 
   Get IMEI of user's phone.
   
   As you might observed, `WXEnvironment.getDevId()` is always be invoked no matter you specify
`android:name="android.permission.READ_PHONE_STATE`  or not since very early version of Weex.
In some phone, calling `getSystemService(Context.TELEPHONY_SERVICE)).getDeviceId()` in code
without corresponding `AndroidManifest` will cause crash. I just updated the Manifest to prevent
possible crash.
   
   https://github.com/apache/incubator-weex/blob/24a30b31e759343668cfe6b8f3de264dd3f586fe/android/sdk/src/main/java/com/taobao/weex/WXEnvironment.java#L404-L405

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message