weex-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-weex] YorkShen commented on a change in pull request #2669: [jsruntime][BreakChange] add runtime code (a/b) and build success
Date Wed, 10 Jul 2019 10:28:47 GMT
YorkShen commented on a change in pull request #2669: [jsruntime][BreakChange] add runtime
code (a/b) and build success
URL: https://github.com/apache/incubator-weex/pull/2669#discussion_r301993885
 
 

 ##########
 File path: dangerfile.js
 ##########
 @@ -246,7 +246,9 @@ const ignoreCopyrightVerifyPath = [
   'ios/playground/bundlejs',
   'ios/sdk/WeexSDK/Resources',
   'ios/sdk/WeexSDK/Sources/Layout',
-  'ios/sdk/WeexSDK/dependency/SRWebSocket'
+  'ios/sdk/WeexSDK/dependency/SRWebSocket',
+  'weex_core/Source/include',
 
 Review comment:
   Change to
   
   ```
   'weex_core/Source/include/JavaScriptCore',
   'weex_core/Source/include/wtf'
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message