weex-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From MrRaindrop <...@git.apache.org>
Subject [GitHub] incubator-weex pull request #558: [html5] update some featrues
Date Wed, 02 Aug 2017 06:30:44 GMT
Github user MrRaindrop commented on a diff in the pull request:

    https://github.com/apache/incubator-weex/pull/558#discussion_r130795311
  
    --- Diff: html5/render/vue/modules/dom.js ---
    @@ -17,14 +17,11 @@
      * under the License.
      */
     import config from '../config'
    -
     const utils = {}
     
     function getParentScroller (vnode) {
       if (!vnode) return null
    -  const vm = vnode.$el
    --- End diff --
    
    This is more readable.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message