weex-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From acton393 <...@git.apache.org>
Subject [GitHub] incubator-weex pull request #495: + [ios] fix bug if duration is 0 or negati...
Date Thu, 06 Jul 2017 08:16:45 GMT
Github user acton393 commented on a diff in the pull request:

    https://github.com/apache/incubator-weex/pull/495#discussion_r125835826
  
    --- Diff: ios/sdk/WeexSDK/Sources/Module/WXAnimationModule.m ---
    @@ -355,7 +360,14 @@ - (void)_createCAAnimation:(WXAnimationInfo *)info
             layer.anchorPoint = CGPointZero;
             layer.frame = originFrame;
         }
    -    [layer addAnimation:animation forKey:info.propertyName];
    +    
    +    if(WXFloatEqual(animation.duration, 0) || WXFloatLessThan(animation.duration, 0)){
    --- End diff --
    
    may be we can provide more function like lessOrEqualThan  and  and greatOrEqualThan value,
here will be more less code 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message