weex-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From weex-bot <...@git.apache.org>
Subject [GitHub] incubator-weex issue #494: + [android] add scroll event on horizontal scroll...
Date Wed, 05 Jul 2017 10:04:09 GMT
Github user weex-bot commented on the issue:

    https://github.com/apache/incubator-weex/pull/494
  
    
    <!--
      1 failure:  This PR modify SD...
      3 warning:  No Changelog chan..., This PR should up..., Potential BREAK C...
      1 messages
      
    -->
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Fails</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:no_entry_sign:</td>
          <td>This PR modify SDK code. Please add/modify corresponding testcases. If
it is ok, please comment about it. Or put '@notdanger' in you commit message.</td>
        </tr>
      </tbody>
    </table>
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Warnings</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:warning:</td>
          <td>No Changelog changes!</td>
        </tr>
      
    <tr>
          <td>:warning:</td>
          <td>This PR should update related documents as well. </td>
        </tr>
      
    <tr>
          <td>:warning:</td>
          <td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/ui/component/WXScroller.java
without metion it in commit message. You'd better add '@notdanger' in your commit log. </td>
        </tr>
      </tbody>
    </table>
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Messages</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:book:</td>
          <td>According to the blame info, we recommended @luics , @zshshr to be the
reviewers.</td>
        </tr>
      </tbody>
    </table>
    
    
    <p align="right">
      Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
    </p>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message