Mailing-List: contact dev-help@velocity.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Velocity Developers List" <dev@velocity.apache.org>
Message-ID: <1041234904.1234374899668.JavaMail.jira@brutus>
Date: Wed, 11 Feb 2009 09:54:59 -0800 (PST)
From: "Nathan Bubna (JIRA)" <dev@velocity.apache.org>
To: velocity-dev@jakarta.apache.org
Subject: [jira] Commented: (VELOCITY-692) have #if handle empty
 strings/arrays/collections/maps more conveniently
In-Reply-To: <1761987350.1234298279725.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/VELOCITY-692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672696#action_12672696 ] 

Nathan Bubna commented on VELOCITY-692:
---------------------------------------

No, you still need to return true if $obj is a non-null object that doesn't return null (or empty string in this case) when calling toString().  So really, if we changed this (which i suspect we could now that #if( $obj == $null ) works right), then it would be false if:

$obj is null
$obj is a false Boolean
$obj has length() that returns > 0
$obj has isEmpty() that returns true
$obj toString() returns string w/length > 0

(false rules seemed easier to write than true)

> have #if handle empty strings/arrays/collections/maps more conveniently
> -----------------------------------------------------------------------
>
>                 Key: VELOCITY-692
>                 URL: https://issues.apache.org/jira/browse/VELOCITY-692
>             Project: Velocity
>          Issue Type: New Feature
>          Components: Engine
>            Reporter: Nathan Bubna
>            Priority: Trivial
>
> An idea from the dev list:
> -------------------------------------------------------------------------------------------------
> On Sat, Feb 7, 2009 at 3:41 PM,  <serg472@gmail.com> wrote:
> > Hello,
> > I wanted to share with you a few ideas I have about new simple
> > improvements for DisplayTools. I should be able to make patches for
> > them if you are interested.
> >
> > 1. Add new method
> >
> > isEmpty(object)
> >
> > that will return true if the object is null or empty (for strings it's
> > zero length; for collections, maps and arrays it's zero size). This
> > should help with  annoying null checks. (Probably a better place for
> > this method would be Engine, not Tools)
> yeah, not something for tools.  would be interesting to have the
> Uberspect pretend that every non-null reference has an isEmpty()
> method, or perhaps just add 0-length strings, empty collections, empty
> maps and 0-length arrays to the list of things that #if( $foo )
> considers false.
> -------------------------------------------------------------------------------------------------

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org