velocity-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Byron Foster (JIRA)" <...@velocity.apache.org>
Subject [jira] Commented: (VELOCITY-681) [regression] Changes on the macro parameters are not persisted outside the macro call
Date Tue, 03 Feb 2009 20:02:05 GMT

    [ https://issues.apache.org/jira/browse/VELOCITY-681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670087#action_12670087
] 

Byron Foster commented on VELOCITY-681:
---------------------------------------

I looked at this some more, and my vote is to release 1.6.2 as it is.  This is obscure behavior
even though we know at least one person who is taking advantage of it.  However,  I would
argue that there are better ways to do this.   LIke I said, Sergiu has a good point about
the behavior change, but fixing it is a real pain with little upside.  I'm pretty confident
that I could find some other obscure error as a result of fixing this.



> [regression] Changes on the macro parameters are not persisted outside the macro call
> -------------------------------------------------------------------------------------
>
>                 Key: VELOCITY-681
>                 URL: https://issues.apache.org/jira/browse/VELOCITY-681
>             Project: Velocity
>          Issue Type: Bug
>          Components: Engine
>    Affects Versions: 1.6.1
>            Reporter: Sergiu Dumitriu
>            Priority: Critical
>             Fix For: 1.6.2, 1.7
>
>         Attachments: VELOCITY-681-1.6.patch, VELOCITY-681-trunk.patch
>
>
> The fix for VELOCITY-615 was too radical, since it completely disables #setting new values
to the formal arguments. A minimalistic example that used to work up to 1.6 (but not with
1.6.1) is:
> {noformat}
> #macro(myMacro $result)
>   #set($result = 'some value')
> #end
> #myMacro($x)
> $x
> {/noformat}
> which prints $x (as an undefined variable).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org


Mime
View raw message