velocity-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nathan Bubna (JIRA)" <...@velocity.apache.org>
Subject [jira] Commented: (VELTOOLS-81) Patch to add escaping for property values and property keys in java properties files.
Date Thu, 05 Apr 2007 16:27:32 GMT

    [ https://issues.apache.org/jira/browse/VELTOOLS-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12487043
] 

Nathan Bubna commented on VELTOOLS-81:
--------------------------------------

Actually, i just did a little investigating.   It looks like the OpenJDK version unfortunately
 won't be acceptable either (see http://people.apache.org/~cliffs/3party.html#category-a for
lists of licenses whose source we can and can't incorporate), since it is under GPLv2.  :(

Looks like it either has to be from Apache Harmony (whose SVN repo is baffling to me) or else
written from scratch. In the latter case, it might be prudent to have you submit a CLA (http://www.apache.org/licenses/icla.txt).
 I know, i don't think any sane person/corporation would really cause problems over this one
little method, but i'm no lawyer and would rather be safe than sorry.  All this is to say,
that the easiest path is probably to find the relevant code in Harmony.   I might take a look
for it at some point, if you don't get to it.   This would be a useful patch to have, and
i do appreciate it!

It's a shame Sun didn't just make the method public or protected in the first place...

> Patch to add escaping for property values and property keys in java properties files.
> -------------------------------------------------------------------------------------
>
>                 Key: VELTOOLS-81
>                 URL: https://issues.apache.org/jira/browse/VELTOOLS-81
>             Project: Velocity Tools
>          Issue Type: Improvement
>          Components: GenericTools
>    Affects Versions: 1.3
>            Reporter: Phil Cornelius
>            Priority: Minor
>         Attachments: escape.patch
>
>
> Special escaping is required when writing keys and values into java properties files.
> I have simply taken the escaping routines from java.util.Properties in the private method
saveConvert(String, boolean) and have added two new methods to propertyKey and propertyValue
used in the same way as the other escaping routines.
> This is useful for example when trying to templatize an install path, say.
> Suppose I have a velocity variable available at runtime $INSTALL_PATH
> I could templatize the following properties thus.
> ----before
> #Policy Director properties file
> #Wed Mar 28 16:26:19 BST 2007
> mgmt_domain=Default
> config_type=standalone
> tcd_enabled=false
> pd-home=C\:\\IBMTest1\\WebSphere\\AppServer/java/jre/PolicyDirector
> pdvar-home=C\:\\IBMTest1\\WebSphere\\AppServer/java/jre/PolicyDirector
> --- templatized
> #Policy Director properties file
> #Wed Mar 28 16:26:19 BST 2007
> mgmt_domain=Default
> config_type=standalone
> tcd_enabled=false
> pd-home=$enc.propertyValue(${INSTALL_PATH})WebSphere\\AppServer/java/jre/PolicyDirector
> pdvar-home=$enc.propertyValue(${INSTALL_PATH})WebSphere\\AppServer/java/jre/PolicyDirector

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org


Mime
View raw message