velocity-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Will Glass-Husain (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (VELOCITY-438) toString is called twice on references
Date Thu, 24 Aug 2006 06:49:41 GMT
     [ http://issues.apache.org/jira/browse/VELOCITY-438?page=all ]

Will Glass-Husain resolved VELOCITY-438.
----------------------------------------

    Resolution: Fixed

patched applied.  sorry for the long delay.  Thanks to Stephen for the patch (and Malcolm
for the reminder :-)

> toString is called twice on references
> --------------------------------------
>
>                 Key: VELOCITY-438
>                 URL: http://issues.apache.org/jira/browse/VELOCITY-438
>             Project: Velocity
>          Issue Type: Bug
>    Affects Versions: 1.5
>            Reporter: Stephen Haberman
>             Fix For: 1.5
>
>         Attachments: call_tostring_only_once.txt
>
>
> ASTReference.java has some null check logic that does, summarized:
> if (value == null || value.toString() == null) {
>    ...
> } else {
>   ... output value.toString();
> }
> Note value.toString() being called twice.
> For strings and other primitives, this may not be a big deal, but I'm happily using Click,
which puts full-fledged components into the velocity context that you render with "$componentName".
Very slick. But now calling toString() multiple times isn't all that cool, both from perf
and logic standpoints.
> I've got a patch if I can figure out how to upload it.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: velocity-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: velocity-dev-help@jakarta.apache.org


Mime
View raw message