velocity-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nbu...@apache.org
Subject svn commit: r488460 - /velocity/tools/trunk/src/java/org/apache/velocity/tools/view/servlet/ServletToolboxManager.java
Date Tue, 19 Dec 2006 00:00:36 GMT
Author: nbubna
Date: Mon Dec 18 16:00:35 2006
New Revision: 488460

URL: http://svn.apache.org/viewvc?view=rev&rev=488460
Log:
spruce up some logging

Modified:
    velocity/tools/trunk/src/java/org/apache/velocity/tools/view/servlet/ServletToolboxManager.java

Modified: velocity/tools/trunk/src/java/org/apache/velocity/tools/view/servlet/ServletToolboxManager.java
URL: http://svn.apache.org/viewvc/velocity/tools/trunk/src/java/org/apache/velocity/tools/view/servlet/ServletToolboxManager.java?view=diff&rev=488460&r1=488459&r2=488460
==============================================================================
--- velocity/tools/trunk/src/java/org/apache/velocity/tools/view/servlet/ServletToolboxManager.java
(original)
+++ velocity/tools/trunk/src/java/org/apache/velocity/tools/view/servlet/ServletToolboxManager.java
Mon Dec 18 16:00:35 2006
@@ -163,7 +163,7 @@
 
                 if (is != null)
                 {
-                    LOG.info("Using config file '" + toolboxFile +"'");
+                    LOG.info("Using config file '" + toolboxFile + "'");
 
                     toolboxManager = new ServletToolboxManager(servletContext);
                     toolboxManager.load(is);
@@ -171,18 +171,16 @@
                     // remember it
                     managersMap.put(uniqueKey, toolboxManager);
 
-                    LOG.info("Toolbox setup complete.");
+                    LOG.debug("Toolbox setup complete.");
+                }
+                else
+                {
+                    LOG.debug("No toolbox was found at '" + toolboxFile + "'");
                 }
             }
             catch(Exception e)
             {
-                LOG.error("Problem loading toolbox '" + toolboxFile +"' : " + e);
-
-                // if this happens, it probably deserves
-                // to have the stack trace logged
-                StringWriter sw = new StringWriter();
-                e.printStackTrace(new PrintWriter(sw));
-                LOG.error(sw.toString());
+                LOG.error("Problem loading toolbox '" + toolboxFile + "'", e);
             }
             finally
             {



Mime
View raw message