From dev-return-6957-archive-asf-public=cust-asf.ponee.io@vcl.apache.org Thu Jan 31 16:08:49 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 8777A180648 for ; Thu, 31 Jan 2019 17:08:48 +0100 (CET) Received: (qmail 8104 invoked by uid 500); 31 Jan 2019 16:08:47 -0000 Mailing-List: contact dev-help@vcl.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@vcl.apache.org Delivered-To: mailing list dev@vcl.apache.org Received: (qmail 8093 invoked by uid 99); 31 Jan 2019 16:08:47 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 31 Jan 2019 16:08:47 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 103FBC7A7E for ; Thu, 31 Jan 2019 16:08:47 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id mCSyhbcpWCEu for ; Thu, 31 Jan 2019 16:08:45 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 783375F4A3 for ; Thu, 31 Jan 2019 16:00:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 1099BE26A5 for ; Thu, 31 Jan 2019 16:00:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 7973B243C3 for ; Thu, 31 Jan 2019 16:00:00 +0000 (UTC) Date: Thu, 31 Jan 2019 16:00:00 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: dev@vcl.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (VCL-1109) date duplicated on statistic graph labels for day after daylight saving time rolls back MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/VCL-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16757403#comment-16757403 ] ASF subversion and git services commented on VCL-1109: ------------------------------------------------------ Commit cc87c75751764937284d869d929ed9714739fa2b in vcl's branch refs/heads/develop from Josh Thompson [ https://gitbox.apache.org/repos/asf?p=vcl.git;h=cc87c75 ] VCL-1109 - date duplicated on statistic graph labels for day after daylight saving time rolls back The fix mentioned in VCL-1109 of just adding a value to the label doesn't really fix the underlying problem and give incorrect values on the graphs. A better fix was to change the timezone to UTC before doing any date work so that DST isn't used. statistics.php: modified getStatGraphDayData, getStatGraphDayConUsersData, getStatGraphConBladeUserData, and getStatGraphConVMUserData: added a call at the beginning of each function to get the current timezone, then set the timezone to UTC; added a call before any returns in each function that sets the timezone back to was was retreived at the beginning of the function > date duplicated on statistic graph labels for day after daylight saving time rolls back > --------------------------------------------------------------------------------------- > > Key: VCL-1109 > URL: https://issues.apache.org/jira/browse/VCL-1109 > Project: VCL > Issue Type: Improvement > Components: web gui (frontend) > Reporter: Josh Thompson > Priority: Major > Fix For: 2.5.1 > > > On the statistic graphs, the day that daylight saving time rolls back is repeated as the label for the date on the day following it and then all labels after that for the graph are off by a day. A simple fix is to add 3600 seconds to the line that generates the label for the date for each function that generates graph points: > $label = date('m/d/Y', $i + 3600); -- This message was sent by Atlassian JIRA (v7.6.3#76005)