tvm-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tianqi Chen <notificati...@github.com>
Subject Re: [dmlc/tvm] [REFACTOR][RFC] Use more TypedPackedFuncs (#2981)
Date Sun, 07 Apr 2019 21:58:45 GMT
Thanks for the contribution, I like the automated detection of the signatures. The main question
is the naming convention to make sure we are not confusing the users. Let us open a new issue
about other parts of RFC. 

I will summarize some of my take here(which can be moved to the RFC).  I like the idea of
Node hierarchy compile time generation. This is something we have thought about for a while
and might help https://github.com/dmlc/tvm/issues/2523#issuecomment-458821056

It is always tempting to automate the wrapper generation. However, our past experience teaches
me that the automatic wrapper generation is never perfect. Think about how can we support
keyword arguments, good pythonic style docstring and so on.  Eventually, we find that it is
simpler to just do a manual wrapping, which gives us all the good native features, docs, and
keep PackedFunc simple (by only support positional arguments without any meta-data).







-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/dmlc/tvm/pull/2981#issuecomment-480633428
Mime
  • Unnamed multipart/alternative (inline, 7-Bit, 0 bytes)
View raw message