tvm-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tianqi Chen <notificati...@github.com>
Subject Re: [dmlc/tvm] [RFC][Relay] Text Format Part 2 (#3016)
Date Sat, 13 Apr 2019 19:20:12 GMT
- Semi-colons: we should not have them, to make most syntax consistent with python
- attrs when it does not match attr's type index
  - This needs more deliberation, it needs to be consistent with the case when we don't print
out BarAttrs(in the meta-data). Or print BarAttrs directly(although not allowed atm), My recommendation
simply use attrs=ValueFormat, where ValueFormat can be any printed format of the attrs

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/dmlc/tvm/issues/3016#issuecomment-482869701
Mime
  • Unnamed multipart/alternative (inline, 7-Bit, 0 bytes)
View raw message