From commits-return-16319-archive-asf-public=cust-asf.ponee.io@tvm.apache.org Thu Jun 25 19:11:27 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 1A016180181 for ; Thu, 25 Jun 2020 21:11:27 +0200 (CEST) Received: (qmail 4783 invoked by uid 500); 25 Jun 2020 19:11:26 -0000 Mailing-List: contact commits-help@tvm.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tvm.apache.org Delivered-To: mailing list commits@tvm.apache.org Received: (qmail 4774 invoked by uid 99); 25 Jun 2020 19:11:26 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Jun 2020 19:11:26 +0000 From: =?utf-8?q?GitBox?= To: commits@tvm.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bincubator-tvm=5D_icemelon9_commented_on_pull_reque?= =?utf-8?q?st_=235826=3A_=5BDYNAMIC=5D_Add_Dynamic_reshape_to_a_dynamic_name?= =?utf-8?q?space_and_add_DynamicToStatic_Pass?= Message-ID: <159311228629.8807.13010543308481611465.asfpy@gitbox.apache.org> Date: Thu, 25 Jun 2020 19:11:26 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: icemelon9 commented on pull request #5826: URL: https://github.com/apache/incubator-tvm/pull/5826#issuecomment-649765936 @mbrookhart Since we separate the static and dynamic reshape in this pr, we should remove the `Optional` in the `ReshapeAttrs` correspondingly. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org