From commits-return-15777-archive-asf-public=cust-asf.ponee.io@tvm.apache.org Fri Jun 19 08:29:13 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id AE5F7180647 for ; Fri, 19 Jun 2020 10:29:12 +0200 (CEST) Received: (qmail 12907 invoked by uid 500); 19 Jun 2020 08:29:12 -0000 Mailing-List: contact commits-help@tvm.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tvm.apache.org Delivered-To: mailing list commits@tvm.apache.org Received: (qmail 12887 invoked by uid 99); 19 Jun 2020 08:29:12 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 Jun 2020 08:29:12 +0000 From: =?utf-8?q?GitBox?= To: commits@tvm.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bincubator-tvm=5D_masahi_commented_on_a_change_in_p?= =?utf-8?q?ull_request_=235834=3A_Improve_type_handling_in_PyTorch_frontend?= Message-ID: <159255535201.8807.17522829914565675673.asfpy@gitbox.apache.org> Date: Fri, 19 Jun 2020 08:29:12 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: masahi commented on a change in pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#discussion_r442707169 ########## File path: python/tvm/relay/frontend/pytorch.py ########## @@ -2120,14 +2146,17 @@ def _get_constant(node): attr_name = attribute_names[0] ty = node.output().type().kind() - if ty in ["IntType", "BoolType"]: + if ty == "IntType": Review comment: why change this? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org