From commits-return-15247-archive-asf-public=cust-asf.ponee.io@tvm.apache.org Fri Jun 12 20:36:26 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 7FAD7180663 for ; Fri, 12 Jun 2020 22:36:26 +0200 (CEST) Received: (qmail 65620 invoked by uid 500); 12 Jun 2020 20:36:25 -0000 Mailing-List: contact commits-help@tvm.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tvm.apache.org Delivered-To: mailing list commits@tvm.apache.org Received: (qmail 65578 invoked by uid 99); 12 Jun 2020 20:36:25 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Jun 2020 20:36:25 +0000 From: =?utf-8?q?GitBox?= To: commits@tvm.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bincubator-tvm=5D_masahi_edited_a_comment_on_pull_r?= =?utf-8?q?equest_=235779=3A_Improve_separation_of_PyTorch_dtypes_and_TVM_dt?= =?utf-8?q?ypes_in_relay_PyTorch_frontend?= Message-ID: <159199418578.8807.4911127598870313522.asfpy@gitbox.apache.org> Date: Fri, 12 Jun 2020 20:36:25 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: masahi edited a comment on pull request #5779: URL: https://github.com/apache/incubator-tvm/pull/5779#issuecomment-643469350 > The user-supplied(!) names are the part before the (last, ha, here only) `.` and they're stable. Do you mean Torch allows users to set the argument name? If you also know when and how exactly Torch changes input names, then sure I can see passing another names for TVM would be annoying. But I'd argue that most users are not familiar with such details of Torchscript, so we shouldn't expect them to correctly deal with names chosen by Torch. Requiring input names are common across other frontends. I think making it optional makes API a bit confusing and we need to explain what input names are expected if omitted, while benefiting only users who are intimately familiar with Torchscript internals. Making the API as close as possible to other frontends also applies to input shapes, so I don't want to make it optional, either. Shapes are required because Relay assumes static input shapes. So my opinion is not make `input_shapes` optional, to keep the API straightforward/less confusing, and close to other frontends. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org