tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] jcf94 edited a comment on pull request #5924: [Arith][GPU]Rewrite simplify fix for Vectorized Cooperative Fetching
Date Fri, 26 Jun 2020 08:18:02 GMT

jcf94 edited a comment on pull request #5924:
URL: https://github.com/apache/incubator-tvm/pull/5924#issuecomment-650045223


   > @jcf94 Did our old rule affect the correctness of common operators?
   
   Yes, with those rules several other UTs will fail.
   For example in `test_arith_intset.py:test_mod()`,
   ```
   ck.verify(flm(y, 8), {y : tvm.arith.IntervalSet(z*8+x*4, z*8+x*4+3)}, (0, 7))
   ```
   Our rules make it to be
   ```
   (((z*8) + (x*4)) - (8*floordiv(((z*8) + (x*4)), 8))), ((((z*8) + (x*4)) + 3) - (8*floordiv(((z*8)
+ (x*4)), 8)))
   ```
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message