tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] t-vi edited a comment on pull request #5887: keep parameter names from PyTorch
Date Tue, 23 Jun 2020 09:02:57 GMT

t-vi edited a comment on pull request #5887:
URL: https://github.com/apache/incubator-tvm/pull/5887#issuecomment-648010250


   I found the problem and will send a fix.
   The old code included the embedding weight twice (which arguably is a bug in itself and
needs fixing) and the new code deduplicated the param but not the var (which is even worse).
   We underappreciate the structure of the PyTorch input...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message