tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] masahi commented on pull request #5834: Improve type handling in PyTorch frontend
Date Fri, 19 Jun 2020 11:03:03 GMT

masahi commented on pull request #5834:
URL: https://github.com/apache/incubator-tvm/pull/5834#issuecomment-646575045


   That 0.2 threshold was chosen arbitrary without a good reason. If you come up with a principled
crieteria it is great. 
   
   Other quantized tests also need a good test criteria (at the moment the outputs are not
tested at all, due to the difficulty in comparing TVM and PyTorch outputs for e2d qmodels).



----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message