tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] Menooker commented on a change in pull request #5601: [DataType] Add bfloat16
Date Wed, 17 Jun 2020 02:48:49 GMT

Menooker commented on a change in pull request #5601:
URL: https://github.com/apache/incubator-tvm/pull/5601#discussion_r441249227



##########
File path: python/tvm/_ffi/runtime_ctypes.py
##########
@@ -96,6 +98,9 @@ def __init__(self, type_str):
             self.type_code = DataTypeCode.HANDLE
             bits = 64
             head = ""
+        elif head.startswith("bfloat"):
+            self.type_code = 4

Review comment:
       > not sure if it is good to hard code here
   
   Change to DataTypeCode. TVM refactors a lot (which is good). And when this PR was raised,
all the type code here used hard codes.
   
   The other two issues you raised were also changed as required.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message