tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] tqchen commented on pull request #5822: fix relay.build to not change the module argument in place
Date Tue, 16 Jun 2020 17:17:17 GMT

tqchen commented on pull request #5822:
URL: https://github.com/apache/incubator-tvm/pull/5822#issuecomment-644898971


   What I would do instead is to simply move `relay_module.CopyOnWrite()` inside `params.size()
!= 0`, which triggers copy if there is additional copy of relay module outside the function.
   
   Note that for mods pass from python, CopyOnWrite always triggers a copy, unless we do `mod._move()`
(moves the python side of the ref)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message