tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] MarisaKirisame commented on pull request #5808: [Relay] Support for ADT in Lazy Gradient Init Pass
Date Tue, 16 Jun 2020 10:04:01 GMT

MarisaKirisame commented on pull request #5808:
URL: https://github.com/apache/incubator-tvm/pull/5808#issuecomment-644667025


   @hypercubestart there is two thing, one is extending relay to work on mutually recursive
function, and one is custom ad pass. can you separate the two and make 2 pr (probably the
mutual recursion one rn, and only the other once it is merged)? by doing this it reduce reviewer
expertise requirement (some ppl know how to do mutual recursion but dont know ad, for example),
and leave better git commit message. generally speaking we should break each pr to do one
thing.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message