tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] tqchen commented on a change in pull request #5816: Type check added for FloatImm
Date Mon, 15 Jun 2020 16:57:33 GMT

tqchen commented on a change in pull request #5816:
URL: https://github.com/apache/incubator-tvm/pull/5816#discussion_r440316185



##########
File path: tests/python/unittest/test_target_custom_datatypes.py
##########
@@ -128,7 +128,7 @@ def test_bfloat_add_and_cast_FloatImm():
     Z = topi.cast(
         topi.add(
             topi.cast(X, dtype="custom[bfloat]16"),
-            tvm.tir.FloatImm("custom[bfloat]16", 1.5)),
+            tvm.tir.FloatImm("float", 1.5)),

Review comment:
       There is a reason why we did not add type check to the codebas here(to support custom
data types) as show in here.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message