tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] masahi edited a comment on pull request #5779: Improve separation of PyTorch dtypes and TVM dtypes in relay PyTorch frontend
Date Fri, 12 Jun 2020 20:36:25 GMT

masahi edited a comment on pull request #5779:
URL: https://github.com/apache/incubator-tvm/pull/5779#issuecomment-643469350


   > The user-supplied(!) names are the part before the (last, ha, here only) `.` and they're
stable.
   
   Do you mean Torch allows users to set the argument name? If you also know when and how
exactly Torch changes input names, then sure I can see passing another names for TVM would
be annoying. But I'd argue that most users are not familiar with such details of Torchscript,
so we shouldn't expect them to correctly deal with names chosen by Torch.
   
   Requiring input names are common across other frontends. I think making it optional makes
API a bit confusing and we need to explain what input names are expected if omitted, while
benefiting only users who are intimately familiar with Torchscript internals. Making the API
as close as possible to other frontends also applies to input shapes, so I don't want to make
it optional, either. Shapes are required because Relay assumes static input shapes.
   
   So my opinion is not make `input_shapes` optional, to keep the API straightforward/less
confusing, and close to other frontends.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message