tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] giuseros commented on pull request #5754: [RFC] Improve quantized convolution performance for armv8 architectures
Date Thu, 11 Jun 2020 14:12:42 GMT

giuseros commented on pull request #5754:
URL: https://github.com/apache/incubator-tvm/pull/5754#issuecomment-642682834


   Hi @FrozenGene , 
   I agree that different strategies should be available to the auto-tuner. See if the solution
proposed is good enough for you (at least as a temporary work-around). For Armv7-A or NCHW,
nothing changes, we follow exactly the previous path. 
   
   For Armv8-A and NHWC we don't convert during the legalization step, but during the `_alter_conv2d_layout`
pass. The only difference now is that the offset contribution will be added after the convolution
instead than before. 
   
   I agree that a better solution, where the legalization changes depending on the strategy,
would be better. However, I don't think the legalization step has got enough information to
know the strategy (for now). 
   
   What do you think?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message