tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] tqchen commented on pull request #5756: make dtype="float" mean float32 for relay.expr.const
Date Wed, 10 Jun 2020 18:02:44 GMT

tqchen commented on pull request #5756:
URL: https://github.com/apache/incubator-tvm/pull/5756#issuecomment-642170343


   Aha, that is definitely interesting.  It is still worth to have a discussion about the
numpy compatibility vs favors common deep learning land.  That could leads to the possibility
of  changing the float to default to `float64`, and we should definitely fix the pytorch frontend.
   
   You are right. In this case consistency is an important issue. As an alternative approach,
we can simply forbid "float" as the type string and force people to specify float32 or float64



----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message