tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] t-vi commented on a change in pull request #5756: make dtype="float" mean float32 for relay.expr.const
Date Wed, 10 Jun 2020 09:21:46 GMT

t-vi commented on a change in pull request #5756:
URL: https://github.com/apache/incubator-tvm/pull/5756#discussion_r437984049



##########
File path: python/tvm/relay/expr.py
##########
@@ -487,6 +487,8 @@ def const(value, dtype=None):
     - bool maps to "bool"
     - other using the same default rule as numpy.
     """
+    if dtype == 'float': # for numpy, float is float64, for us it is float32
+        dtype = 'float32'

Review comment:
       So what do you suggest as a better position?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message