tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] icemelon9 commented on a change in pull request #4312: [TOPI][Relay][OP] Dynamic NMS and strided_slice
Date Tue, 09 Jun 2020 15:48:43 GMT

icemelon9 commented on a change in pull request #4312:
URL: https://github.com/apache/incubator-tvm/pull/4312#discussion_r437068289



##########
File path: python/tvm/relay/op/vision/nms.py
##########
@@ -69,13 +73,18 @@ def non_max_suppression(data,
     Parameters
     ----------
     data : relay.Expr
-        3-D tensor with shape [batch_size, num_anchors, 6].
+        3-D tensor with shape [batch_size, num_anchors, 6]
+        or [batch_size, num_anchors, 5].
         The last dimension should be in format of
-        [class_id, score, box_left, box_top, box_right, box_bottom].
+        [class_id, score, box_left, box_top, box_right, box_bottom]
+        or [score, box_left, box_top, box_right, box_bottom].
 
     valid_count : relay.Expr
         1-D tensor for valid number of boxes.
 
+    indices: relay.Expr
+        2-D tensor with shape [batch_size, num_anchors]

Review comment:
       Please be more specific of what `indices` is.
   
   

##########
File path: topi/python/topi/cuda/nms.py
##########
@@ -351,6 +358,9 @@ def non_max_suppression(data, valid_count, max_output_size=-1,
     valid_count : tvm.te.Tensor
         1-D tensor for valid number of boxes.
 
+    indices : tvm.te.Tensor
+        2-D tensor with shape [batch_size, num_anchors].

Review comment:
       Please be more specific of what `indices` is.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message