tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] tqchen commented on a change in pull request #5738: [REFACTOR][ARITH] Remove legacy compute_expr.h
Date Sat, 06 Jun 2020 03:06:51 GMT

tqchen commented on a change in pull request #5738:
URL: https://github.com/apache/incubator-tvm/pull/5738#discussion_r436231973



##########
File path: include/tvm/tir/op.h
##########
@@ -762,6 +778,15 @@ inline PrimExpr make_zero(DataType t) {
   }
   return make_const(t, 0);
 }
+
+template <typename FReduce>
+inline PrimExpr foldl(FReduce freduce, PrimExpr init_value, const Array<PrimExpr>&
values) {

Review comment:
       most of the functions in this file uses stl_case(as they are part of user facing function),
we can discuss whether we want to force all function to conform to the CamelCase later.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message