tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] t-vi commented on a change in pull request #5727: ROCm warp shuffles and reductions
Date Thu, 04 Jun 2020 18:31:58 GMT

t-vi commented on a change in pull request #5727:
URL: https://github.com/apache/incubator-tvm/pull/5727#discussion_r435466266



##########
File path: tests/python/unittest/test_tir_transform_lower_warp_memory.py
##########
@@ -249,9 +245,13 @@ def check(m):
             B_np = A_np + 1
             tvm.testing.assert_allclose(B_nd.asnumpy(), B_np)
 
-    check(m=31)
-    check(m=32)
-    check(m=33)
+    for device in ['cuda', 'rocm']:
+        if not tvm.context(device, 0).exist or not tvm.runtime.enabled(device):
+            print("skip because", device,"is not enabled..")
+            continue
+        check(device, m=31)

Review comment:
       Tank you for your comments! I added both and rebased.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message