tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] ANSHUMAN87 commented on pull request #5725: [Bugfix][Serialization] Fix runtime::String backward compatibility in JSON
Date Thu, 04 Jun 2020 09:30:28 GMT

ANSHUMAN87 commented on pull request #5725:
URL: https://github.com/apache/incubator-tvm/pull/5725#issuecomment-638734857


   Thanks @junrushao1994 !
   As i remember, I had handled version upgrade for "GlobalVar" in PR (#5547).
   So maybe we need to discuss how it got bypassed?
   I saw the changes in jason_compact.py, just wonder why below code did not work:
   `"relay.GlobalVar": [_rename("GlobalVar"), _update_from_std_str("name_hint")],`
   
   I understand the issue is because of the key name difference "relay.Global" vs "Global".
   Please correct me if my understanding is wrong.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message