tvm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-tvm] ANSHUMAN87 commented on a change in pull request #5718: [Object][FFI] Introduce runtime::String::CanConvertFrom
Date Wed, 03 Jun 2020 05:09:32 GMT

ANSHUMAN87 commented on a change in pull request #5718:
URL: https://github.com/apache/incubator-tvm/pull/5718#discussion_r434310738



##########
File path: src/ir/attrs.cc
##########
@@ -37,7 +37,7 @@ void DictAttrsNode::InitByPackedArgs(const runtime::TVMArgs& args, bool
allow_un
     runtime::TVMArgValue val = args[i + 1];
     if (val.IsObjectRef<ObjectRef>()) {
       dict.Set(key, val.operator ObjectRef());
-    } else if (val.type_code() == kTVMStr) {
+    } else if (String::CanConvertFrom(val)) {

Review comment:
       > Thank you for your question! Hmmmm but I am not sure I understand if correctly.
Just to confirm, "The first if condition", are you referring to "val.type_code() == kTVMStr"
in `CanConvertFrom`? Thank you!
   Sorry for confusion.
   The first if condition --> if (val.IsObjectRef<ObjectRef>())




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message