From commits-return-14232-archive-asf-public=cust-asf.ponee.io@tvm.apache.org Thu May 28 23:15:05 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id C1F05180643 for ; Fri, 29 May 2020 01:15:04 +0200 (CEST) Received: (qmail 63349 invoked by uid 500); 28 May 2020 23:15:04 -0000 Mailing-List: contact commits-help@tvm.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tvm.apache.org Delivered-To: mailing list commits@tvm.apache.org Received: (qmail 63340 invoked by uid 99); 28 May 2020 23:15:04 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 May 2020 23:15:04 +0000 From: =?utf-8?q?GitBox?= To: commits@tvm.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bincubator-tvm=5D_mbaret_commented_on_pull_request_?= =?utf-8?q?=235689=3A_=5BPatternLang=5D_Add_ConstantPattern?= Message-ID: <159070770385.10999.9866272123075943002.asfpy@gitbox.apache.org> Date: Thu, 28 May 2020 23:15:03 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: mbaret commented on pull request #5689: URL: https://github.com/apache/incubator-tvm/pull/5689#issuecomment-635665317 It's not really the case that old merge composite explicitly 'lifts' constant nodes if they're vars, in old merge composite vars indicate inputs to the pattern (so they don't need to explicitly match against a VarNode). My expectation would be if the pattern requires there to be a constant node, I should see that constant node in the partitioned function. In other words, the body of the function should still match the pattern used to create it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org