From commits-return-14161-archive-asf-public=cust-asf.ponee.io@tvm.apache.org Wed May 27 23:50:04 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 874B1180626 for ; Thu, 28 May 2020 01:50:04 +0200 (CEST) Received: (qmail 28542 invoked by uid 500); 27 May 2020 23:50:03 -0000 Mailing-List: contact commits-help@tvm.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tvm.apache.org Delivered-To: mailing list commits@tvm.apache.org Received: (qmail 28533 invoked by uid 99); 27 May 2020 23:50:03 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 May 2020 23:50:03 +0000 From: =?utf-8?q?GitBox?= To: commits@tvm.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bincubator-tvm=5D_kevinthesun_commented_on_a_change?= =?utf-8?q?_in_pull_request_=235684=3A_=5BAutoTVM=5D=5BTOPI=5D_Fix_bifrost_s?= =?utf-8?q?patial_packing_conv2d_auto_tune?= Message-ID: <159062340371.10999.15255687799308694061.asfpy@gitbox.apache.org> Date: Wed, 27 May 2020 23:50:03 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: kevinthesun commented on a change in pull request #5684: URL: https://github.com/apache/incubator-tvm/pull/5684#discussion_r431505903 ########## File path: topi/python/topi/bifrost/conv2d.py ########## @@ -142,13 +142,14 @@ def _schedule_spatial_pack(cfg, s, output, conv, data_vec, kernel_vec): s[data_vec].unroll(vw) if isinstance(kernel_vec.op, tvm.te.ComputeOp) and kernel_vec.name == 'kernel_vec': + co, ci, kh, kw, vc = s[kernel_vec].op.axis Review comment: Actually I'm not quite sure whether we can directly do this kind of placeholder replacement inside schedule. https://github.com/apache/incubator-tvm/pull/5511 for mali might also has issue. Put placeholder replacement in compute would be more convenient. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org