From commits-return-14004-archive-asf-public=cust-asf.ponee.io@tvm.apache.org Sat May 23 06:10:10 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 73260180634 for ; Sat, 23 May 2020 08:10:10 +0200 (CEST) Received: (qmail 73409 invoked by uid 500); 23 May 2020 06:10:09 -0000 Mailing-List: contact commits-help@tvm.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tvm.apache.org Delivered-To: mailing list commits@tvm.apache.org Received: (qmail 73399 invoked by uid 99); 23 May 2020 06:10:09 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 23 May 2020 06:10:09 +0000 From: =?utf-8?q?GitBox?= To: commits@tvm.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bincubator-tvm=5D_Shawn-Inspur_commented_on_a_chang?= =?utf-8?q?e_in_pull_request_=235600=3A_=5BTOPI=5D_Improve_CUDA_softmax_sche?= =?utf-8?q?duling?= Message-ID: <159021420931.19379.1991887016313983708.asfpy@gitbox.apache.org> Date: Sat, 23 May 2020 06:10:09 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: Shawn-Inspur commented on a change in pull request #5600: URL: https://github.com/apache/incubator-tvm/pull/5600#discussion_r429518516 ########## File path: topi/python/topi/cuda/softmax.py ########## @@ -53,13 +54,61 @@ def schedule_softmax(outs): raise ValueError('Tag is expected to be softmax_output or log_softmax_output. \ Got {0}'.format(op_tag)) + # The nvptx backend only supports 32-bits warp shuffle instructions. + # + # TODO(tvm-team) Fix nvptx codegen or deprecate nvptx backend. + def sched_warp_softmax(): + if tgt.target_name == "nvptx": + return softmax.dtype == "float32" or softmax.dtype == "int32" + return True Review comment: This makes sense to me. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org