From commits-return-13863-archive-asf-public=cust-asf.ponee.io@tvm.apache.org Thu May 21 22:17:58 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id F2CAF1804BB for ; Fri, 22 May 2020 00:17:57 +0200 (CEST) Received: (qmail 68418 invoked by uid 500); 21 May 2020 22:17:57 -0000 Mailing-List: contact commits-help@tvm.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tvm.apache.org Delivered-To: mailing list commits@tvm.apache.org Received: (qmail 68409 invoked by uid 99); 21 May 2020 22:17:57 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 May 2020 22:17:57 +0000 From: =?utf-8?q?GitBox?= To: commits@tvm.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bincubator-tvm=5D_mbaret_commented_on_a_change_in_p?= =?utf-8?q?ull_request_=235646=3A_Add_a_check_Callback_to_the_Pattern_Pariti?= =?utf-8?q?oner?= Message-ID: <159009947719.19379.13030843182296370583.asfpy@gitbox.apache.org> Date: Thu, 21 May 2020 22:17:57 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: mbaret commented on a change in pull request #5646: URL: https://github.com/apache/incubator-tvm/pull/5646#discussion_r428945990 ########## File path: include/tvm/relay/dataflow_matcher.h ########## @@ -90,7 +91,8 @@ Expr RewritePatterns(Array callbacks, Expr expr); * * \return Return the paritioned Expr. */ -Expr PartitionPattern(DFPattern pattern, Expr expr); Review comment: That is surprising, alright no worries then. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org