From commits-return-13666-archive-asf-public=cust-asf.ponee.io@tvm.apache.org Tue May 19 19:04:47 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id D9017180638 for ; Tue, 19 May 2020 21:04:46 +0200 (CEST) Received: (qmail 72219 invoked by uid 500); 19 May 2020 19:04:46 -0000 Mailing-List: contact commits-help@tvm.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tvm.apache.org Delivered-To: mailing list commits@tvm.apache.org Received: (qmail 72210 invoked by uid 99); 19 May 2020 19:04:46 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 May 2020 19:04:46 +0000 From: =?utf-8?q?GitBox?= To: commits@tvm.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bincubator-tvm=5D_yongwww_commented_on_a_change_in_?= =?utf-8?q?pull_request_=234312=3A_=5BTOPI=5D=5BRelay=5D=5BOP=5D_Dynamic_NMS?= =?utf-8?q?_and_strided=5Fslice?= Message-ID: <158991508619.19379.14397213455865681643.asfpy@gitbox.apache.org> Date: Tue, 19 May 2020 19:04:46 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: yongwww commented on a change in pull request #4312: URL: https://github.com/apache/incubator-tvm/pull/4312#discussion_r427533768 ########## File path: src/relay/op/vision/nms.cc ########## @@ -136,8 +143,9 @@ TVM_REGISTER_API("relay.op.vision._make.non_max_suppression") RELAY_REGISTER_OP("vision.non_max_suppression") .describe(R"doc(Non-maximum suppression. The input boxes should -be in the format of [class_id, score, left, top, right, bottom]. -Set id_index to be -1 to ignore class_id axis. +be in the format of [class_id, score, left, top, right, bottom] +or [score, left, top, right, bottom]. Set id_index to be -1 to Review comment: yes ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org