From commits-return-13476-archive-asf-public=cust-asf.ponee.io@tvm.apache.org Sat May 16 02:34:34 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 2F73E180608 for ; Sat, 16 May 2020 04:34:34 +0200 (CEST) Received: (qmail 95477 invoked by uid 500); 16 May 2020 02:34:33 -0000 Mailing-List: contact commits-help@tvm.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tvm.apache.org Delivered-To: mailing list commits@tvm.apache.org Received: (qmail 95455 invoked by uid 99); 16 May 2020 02:34:32 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 16 May 2020 02:34:32 +0000 From: =?utf-8?q?GitBox?= To: commits@tvm.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bincubator-tvm=5D_masahi_commented_on_pull_request_?= =?utf-8?q?=235098=3A_=5BTOPI=5D=5BRELAY=5DGlobal_MaxPool3d_and_AvgPool3d_to?= =?utf-8?q?pi_=26_relay_implementation?= Message-ID: <158959647244.19379.11022058218410384452.asfpy@gitbox.apache.org> Date: Sat, 16 May 2020 02:34:32 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: masahi commented on pull request #5098: URL: https://github.com/apache/incubator-tvm/pull/5098#issuecomment-629576125 I think we shouldn't introduce this op for the reason I mentioned. If we want to use this op to convert `global_avg_pool` from frontends, we can define `global_avg_pool` function in frontend/common.py that just calls `adaptive_pool` with output size (1, 1). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org