From commits-return-13245-archive-asf-public=cust-asf.ponee.io@tvm.apache.org  Sun May 10 05:26:07 2020
Return-Path: <commits-return-13245-archive-asf-public=cust-asf.ponee.io@tvm.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [207.244.88.153])
	by mx-eu-01.ponee.io (Postfix) with SMTP id B37DD180654
	for <archive-asf-public@cust-asf.ponee.io>; Sun, 10 May 2020 07:26:06 +0200 (CEST)
Received: (qmail 43235 invoked by uid 500); 10 May 2020 05:26:06 -0000
Mailing-List: contact commits-help@tvm.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:commits-help@tvm.apache.org>
List-Unsubscribe: <mailto:commits-unsubscribe@tvm.apache.org>
List-Post: <mailto:commits@tvm.apache.org>
List-Id: <commits.tvm.apache.org>
Reply-To: dev@tvm.apache.org
Delivered-To: mailing list commits@tvm.apache.org
Received: (qmail 43225 invoked by uid 99); 10 May 2020 05:26:06 -0000
Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 10 May 2020 05:26:06 +0000
From: =?utf-8?q?GitBox?= <git@apache.org>
To: commits@tvm.apache.org
Subject: =?utf-8?q?=5BGitHub=5D_=5Bincubator-tvm=5D_ANSHUMAN87_commented_on_a_change_?=
 =?utf-8?q?in_pull_request_=235547=3A_=5BRefactor=5D=5Bstd=3A=3Astring_--=3E?=
 =?utf-8?q?_String=5D_IR_is_updated_with_String?=
Message-ID: <158908836599.4590.16075465199449288410.asfpy@gitbox.apache.org>
Date: Sun, 10 May 2020 05:26:05 -0000
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
References: <incubator-tvm.5547.MDExOlB1bGxSZXF1ZXN0NDE1NDQzNzI5.gitbox@gitbox.apache.org>
In-Reply-To: <incubator-tvm.5547.MDExOlB1bGxSZXF1ZXN0NDE1NDQzNzI5.gitbox@gitbox.apache.org>


ANSHUMAN87 commented on a change in pull request #5547:
URL: https://github.com/apache/incubator-tvm/pull/5547#discussion_r422587536



##########
File path: src/ir/attrs.cc
##########
@@ -53,9 +53,13 @@ Array<AttrFieldInfo> DictAttrsNode::ListFieldInfo() const {
   return {};
 }
 
-DictAttrs::DictAttrs(Map<std::string, ObjectRef> dict) {
+DictAttrs::DictAttrs(Map<String, ObjectRef> dict) {
   ObjectPtr<DictAttrsNode> n = make_object<DictAttrsNode>();
-  n->dict = std::move(dict);
+  Map<std::string, ObjectRef> dict_copy;
+  for (auto iter : dict) {

Review comment:
       @tqchen : You are right! It was an effort to isolate independent commits, so that the dependency can be broken down. Will revert it for now!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org